feat: adding support for amdama (supernova) gpus release 1.5#8643
Open
mipresmsft wants to merge 3 commits into
Open
feat: adding support for amdama (supernova) gpus release 1.5#8643mipresmsft wants to merge 3 commits into
mipresmsft wants to merge 3 commits into
Conversation
mipresmsft
requested review from
AbelHu,
Devinwong,
SriHarsha001,
awesomenix,
calvin197,
cameronmeissner,
djsly,
ganeshkumarashok,
lilypan26,
mxj220,
pdamianov-dev,
phealy,
r2k1,
sulixu,
surajssd,
timmy-wright and
zachary-bailey
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Linux CSE + e2e coverage to support provisioning/validation for AMD AMA (Supernova / MA35D) GPUs release 1.5, primarily on Azure Linux v3, and adjusts e2e firewall rules accordingly.
Changes:
- Updates Azure Linux MA35D provisioning logic to discover/install AMD AMA driver/firmware and derive matching “core” package coordinates.
- Adds/updates MA35D e2e validation and simplifies the scenario’s system pool SKU usage (defaults).
- Removes
download.microsoft.comfrom the e2e firewall allowlist.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| parts/linux/cloud-init/artifacts/cse_config.sh | Reworks AMD AMA install flow (repoquery-based driver selection, firmware install, core package URL construction). |
| e2e/scenario_test.go | Tweaks AzureLinuxV3 MA35D scenario config (removes explicit system pool SKU override). |
| e2e/aks_model.go | Removes download.microsoft.com from Azure Firewall application rules used by e2e. |
Comment on lines
+1148
to
+1152
| AMD_AMA_FIRMWARE_PACKAGE="${AMD_AMA_DRIVER_PACKAGE/driver/firmware}" | ||
| if [ -z "$AMD_AMA_DRIVER_PACKAGE" ]; then | ||
| echo "Unable to find AMD AMA firmware package for current kernel version, exiting..." | ||
| exit $ERR_AMDAMA_DRIVER_NOT_FOUND | ||
| fi |
Comment on lines
+1169
to
+1170
| TMP="${AMD_AMA_DRIVER_PACKAGE#amd-ama-driver-*:}"; AMD_AMA_DRIVER_VERSION="${TMP%%_*}" | ||
| TMP2="${TMP#*_}"; AMD_AMA_DRIVER_BUILD_NUMBER="${TMP2%%-*}" |
Comment on lines
+1109
to
+1113
| name=$1; ver=$2; bld=$3; retries=$4; wait_sleep=$5; timeout=$6; shift && shift && shift && shift && shift && shift | ||
| AMD_AMA_PACKAGE="https://packages.xilinx.com/artifactory/rpm-packages/x86_64/amd-ama-${name}_${ver}-${bld}.x86_64.rpm" | ||
| for i in $(seq 1 $retries); do | ||
| # RPM_FRONTEND env variable needed to disable license agreement prompt | ||
| RPM_FRONTEND=noninteractive dnf install -y https://download.microsoft.com/download/16b04fa7-883e-4a94-88c2-801881a47b28/amd-ama-core_1.3.0-2503242033-amd64.rpm && break || \ | ||
| RPM_FRONTEND=noninteractive dnf install -y $AMD_AMA_PACKAGE && break || \ |
Comment on lines
+1130
to
+1134
| if isAzureLinux "$OS"; then | ||
| # Install MA35D packages - currently version 1.5 and above are supported | ||
| # This install script will extract the driver version/build number to find | ||
| # the corresponding core/FW packages | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates node provisioning + e2e validation support for AMD AMA (Supernova / MA35D) GPUs release 1.5 in the Linux CSE flow, primarily targeting Azure Linux v3. New naming scheme should also be forward compatible with future driver/SW releases from AMD.
Changes:
Update AMD AMA install logic.
Update e2e coverage with MA35D scenarios, remove download.microsoft.com in the e2e firewall.